View Issue Details

IDProjectCategoryView StatusLast Update
0001901T99X171.00 SKB EagleSWpublic2024-03-29 11:33
Reporter(ALTech) Sangmin Choi Assigned To(ALTech) Sangmin Choi Due Date2024-03-11 13:00
PrioritynormalSeveritys4-minorReproducibilityN/A
Status closedResolutionfixed 
Summary0001901: Implement DISPLAY_HDR_GetSupportedInfo function for BTF_API_LEVEL_8.
DescriptionHello, Jason,

Please implement DISPLAY_HDR_GetSupportedInfo function for BTF_API_LEVEL_8.
Target branch is 542(OS12).
SKB jira ticket is https://jira.skbroadband.com/browse/BPM-28325.

You can find the specification of function in vendor/skb/framework/hal/interface/btv_hal.h

/**
** @brief
** get HDMI HDR Supported list

**
** @param[in] display the display module handle
** @param[out] hdr_list supported HDR list value (ex "HDR HDR10 HDR10+ DolbyVision") : delimeter=" " 미지원시 value ""
**
** @retval 0 DISPLAY_HDR_GetSupportedInfo successfully.
** @retval -1 error occurred or DISPLAY_HDR_GetSupportedInfo failed.
**
*/
int DISPLAY_HDR_GetSupportedInfo(DISPLAY_HANDLE display, char* hdr_list);

If you have any question, please let me know.

Thank you.
TagsNo tags attached.
Attach Tags

Users monitoring this issue

Activities

(ALTech) Sangmin Choi

2024-03-06 14:34

developer   ~0015214

Hello, Jason,

Could you please check this ticket?

If TV not support any HDR feature, the hdr_list should set as "".
If TV support HDR only, the hdr_list should set as "HDR".
If TV support HDR and HDR10, the hdr_list should set as "HDR HDR10".
(...Examples of other cases are omitted...)

The size of hdr_list is 256.

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-12 08:19

developer   ~0015233

Hello, Jerry,

Could you please let me know progress of this ticket?

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-14 14:21

developer   ~0015240

Hello, Jerry,

Could you please let me know progress of this ticket?

Thank you.
Sangmin Choi.

(SW) Jerry Lin

2024-03-14 15:04

developer   ~0015241

Hi Sangmin ,
I I have a test FW but i don't know how to check this function.
Does the current UI support this function?

Jerry

(ALTech) Sangmin Choi

2024-03-14 16:02

developer   ~0015242

Hello, Jerry,

Please apply this patch to vendor/skb/framework/hal/testsuite.
You can test with following command.

$ su
# bts hdr_supported_info

And, I'm sorry I'm out of office, so I didn't test this code.
If you have any problem, please let me know.

Thank you.
Sangmin Choi.
test_function_DISPLAY_HDR_GetSupportedInfo.patch (1,543 bytes)   
diff --git a/btf_main.c b/btf_main.c
old mode 100644
new mode 100755
index f457445..fea6327
--- a/btf_main.c
+++ b/btf_main.c
@@ -397,6 +397,13 @@ int main(int argc, char *argv[])
 			LOGD(" duration : %d, type : %d, hdmiCecMessage : %s\n", durationMinute, type, hdmiCecMessage);
 
 			display14_hdmi_cec_send_message(durationMinute, newListPlayerConfig[0], type, hdmiCecMessage);
+		} else if(strcmp(argv[1], "hdr_supported_info") == 0) {
+			int durationMinute = DEFAULT_DURATION;
+			char hdr_list[256];
+			LOGD(" duration : %d\n", durationMinute);
+
+			display15_hdr_supported_info(durationMinute, hdr_list);
+			LOGD("[BTS|%s:%d] hdr supported info : %d\n", __FUNCTION__, __LINE__, hdr_list);
 		} else if(strcmp(argv[1], MENU_DEVICE01_LED_STATE) == 0) {
 			int ledId = -1, state = -1;
 			if(argc < 4){
diff --git a/display.c b/display.c
old mode 100644
new mode 100755
index 5dff852..42d4e53
--- a/display.c
+++ b/display.c
@@ -546,3 +546,22 @@ void display14_hdmi_cec_send_message(int durationMinute, AVP_PlayerConfig player
 
 	FUNCTION_OUT();
 }
+
+void display15_hdr_supported_info(int durationMinute, char *hdr_list) {
+	FUNCTION_IN();
+
+	if(DISPLAY_Create(&displayHandle) != 0) {
+		LOGD("DISPLAY_Create create fail.");
+		assert(false);
+	}
+
+	if(DISPLAY_HDR_GetSupportedInfo(displayHandle, hdr_list) != 0) {
+		LOGE("[BTS|%s:%d] DISPLAY_HDR_GetSupportedInfo fail.", __FUNCTION__, __LINE__);
+		assert(false);
+	}
+
+	if(displayHandle != NULL)
+		DISPLAY_Destroy(displayHandle);
+
+	FUNCTION_OUT();
+}

(SW) Jerry Lin

2024-03-15 09:05

developer   ~0015244

Hi Sangmin ,
The following message is my test result for HDR info.
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
03-14 21:26:06.906 7744 7744 D Display : BTF|DISPLAY_HDR_GetSupportedInfo|853|IN| display:0xc87144e0
03-14 21:26:06.906 7744 7744 D hal_display: hal_display:HAL_DISPLAY_HDR_GetSupportedInfo
03-14 21:26:06.906 7744 7744 D hal_display: hal_display:Start get HDR info
03-14 21:26:06.907 7744 7744 D hal_display: hal_display:Get HDR10
03-14 21:26:06.907 7744 7744 D hal_display: hal_display:Get HDR10+
03-14 21:26:06.907 7744 7744 D hal_display: hal_display:End get HDR info
03-14 21:26:06.907 7744 7744 D Display : BTF|DISPLAY_HDR_GetSupportedInfo|861|OUT|HDR10 HDR10+|
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info : -1389536


I also send you the SD test FW , please help to verify the feature in your side.
Thanks.

Jerry

(ALTech) Sangmin Choi

2024-03-15 09:26

developer   ~0015245

Hello, Jerry,

OMG,,there is mistake in the patch.
Could you please change the following line?

+ LOGD("[BTS|%s:%d] hdr supported info : %d\n", __FUNCTION__, __LINE__, hdr_list);
+ LOGD("[BTS|%s:%d] hdr supported info : %s\n", __FUNCTION__, __LINE__, hdr_list);

Sorry again.

(SW) Jerry Lin

2024-03-15 09:28

developer   ~0015246

Hi Sangmin ,
Ok ,
If the FW is ok , i will upload to ALT server.

Jerry

(SW) Jerry Lin

2024-03-15 10:41

developer   ~0015247

Hi Sangmin ,
The following message is my test result for HDR info.
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
03-15 10:49:27.445 8880 8880 D Display : BTF|DISPLAY_HDR_GetSupportedInfo|853|IN| display:0xc69144e0
03-15 10:49:27.445 8880 8880 D hal_display: hal_display:HAL_DISPLAY_HDR_GetSupportedInfo
03-15 10:49:27.445 8880 8880 D hal_display: hal_display:Start get HDR info
03-15 10:49:27.445 8880 8880 D hal_display: hal_display:Get HDR10
03-15 10:49:27.445 8880 8880 D hal_display: hal_display:Get HDR10+
03-15 10:49:27.446 8880 8880 D hal_display: hal_display:End get HDR info
03-15 10:49:27.446 8880 8880 D Display : BTF|DISPLAY_HDR_GetSupportedInfo|861|OUT|HDR10 HDR10+|
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info : HDR10 HDR10+


The SD test FW upload to
/release_by_fxn/smart3_test/20240315_mantis1901

Jerry

(ALTech) Sangmin Choi

2024-03-15 13:37

developer   ~0015250

Hello, Jerry,

When I connect the TV which is not supported HDR function, I can see the following log message.

BFX-AT100:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
[BTS|display15_hdr_supported_info:559] DISPLAY_HDR_GetSupportedInfo fail.
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info :

The return value of DISPLAY_HDR_GetSupportedInfo function is true if the TV is not supported HDR function.
It's enough that the hdr_list is set as "".

Please return value as error in case of the failure of DISPLAY_HDR_GetSupportedInfo function.

Thank you.
Sangmin Choi.

(SW) Jerry Lin

2024-03-15 15:32

developer   ~0015251

Hi Sangmin,
The return value of DISPLAY_HDR_GetSupportedInfo function is true if the TV is not supported HDR function.
--> The value is -1 and the hdr_list is set as "", right ?

Jerry

(ALTech) Sangmin Choi

2024-03-15 15:42

developer   ~0015252

No, if the TV doesn't support HDR function,
-> return value is 0, because you can read information about HDR.
-> hdr_list is set as ""

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-18 08:29

developer   ~0015255

Hello, Jerry,

Could you please provide the test result of following cases?

- HDR doesn't support TV
- HDR/HDR10/HDR10+ support TV
- Dolby Vision support TV

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-18 16:38

developer   ~0015259

Hello, Jerry,

Please stop to implement this function.
The specification will be changed soon, I will let you know the details.

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-19 13:17

developer   ~0015261

Hello, Jerry,

I want to set the specification as follows.

DISPLAY_HDR_GetSupportedInfo should set the supported TV and STB feature.
So, Smart3 doesn't support Dolby Vision, so if Dolby Vision support TV connected, then DISPLAY_HDR_GetSupportedInfo doesn't set the hdr_list as DolbyVision.

Please check the following pseudocode.

DISPLAY_HDR_GetSupportedInfo(DISPLAY_HANDLE display, char* hdr_list)
    initialize the hdr_list variable
    
    if TV support HDR, append "HDR" to hdr_list
    if TV support HDR10, append " " to hdr_list as delimiter, and append "HDR10" to hdr_list.
    if TV support HDR10+, append " " to hdr_list as delimiter, and append "HDR10+" to hdr_list.
    if TV support Dolby Vision, do nothing. Because Smart3 doesn't support Dolby Vision feature.

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-19 13:23

developer   ~0015262

CC : Kerwin

(SW) Jerry Lin

2024-03-20 09:24

developer   ~0015267

Hi Sangmin,
Please help to check the attached file for hdr_list and return value.

Jerry
HDR.xlsx (9,742 bytes)

(ALTech) Sangmin Choi

2024-03-20 09:49

developer   ~0015268

Hello, Jerry,

It's perfect, I think there is no missed case.

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-25 16:00

developer   ~0015295

Hello, Jerry,

Could you please update current ticket?

Thank you.
Sangmin Choi.

(SW) Jerry Lin

2024-03-25 20:07

developer   ~0015296

Hi Sangmin ,
I will remove DV infomation from the DISPLAY_HDR_GetSupportedInfo.
I also release a SD test FW to you tomorrow.
Please help me to confirm whether this behavior is correct.

I will check 3 TVs in my side.

Jerry



Jerry

(ALTech) Sangmin Choi

2024-03-28 08:31

developer   ~0015321

Hello, Jerry,

Could you please share the test result of yours and test firmware?

Thank you.
Sangmin Choi.

(SW) Jerry Lin

2024-03-28 15:48

developer   ~0015327

Hi Sangmin ,
I test 4 TV's in my side and also update SD test FW to ALT's server.
i upload to /release_by_fxn/smart3_test/20240328_mantis1901


////////////////// SAMSUNG UA43RU7400W /////////////////
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info : HDR10 HDR10+


////////////////// SHARP LC-40V7 (No HDR) /////////////////
126|console:/ $ su
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info :


//////////// SHARP 4T-C60BJ1T /////////////////
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info : HDR HDR10


//////////// LG OLED55B7T-D (DolbyVision TV) ////////////////////////
console:/ # bts hdr_supported_info
[command : hdr_supported_info]

 duration : 999999

[BTS|display15_hdr_supported_info:551] in
[BTS|display15_hdr_supported_info:566] out
[BTS|main:406] hdr supported info : HDR10

Jerry

(ALTech) Sangmin Choi

2024-03-29 08:55

developer   ~0015330

Hello, Jerry,

When I run the "bts hdr_supported_info" command, I can see following messages.

03-29 09:53:16.984 10857 - D hw-ProcessState Binder ioctl to enable oneway spam detection failed: Invalid argument
03-29 09:53:16.986 0 - I [ 748.424213@1]- binder 10857:10857 ioctl 40046210 ffb12318 returned -22

Could you please check what this message is?

Thank you.
Sangmin Choi.

(ALTech) Sangmin Choi

2024-03-29 09:46

developer   ~0015332

Hello, Jerry,

That messages are related with bts binary, so we can ignore it.
Please push modifications to 542 branches.

Please use the "[BPM-28325]" as the prefix of commit message.
And, do NOT push the test function I gave you(test_function_DISPLAY_HDR_GetSupportedInfo.patch).

Thank you.
Sangmin Choi.

(SW) Jerry Lin

2024-03-29 10:34

developer   ~0015333

Hi Sangmin,
commit done!

Jerry

(ALTech) Sangmin Choi

2024-03-29 11:33

developer   ~0015336

Thank you, Jerry!

Issue History

Date Modified Username Field Change
2024-03-06 14:22 (ALTech) Sangmin Choi New Issue
2024-03-06 14:34 (ALTech) Sangmin Choi Assigned To => (SW) Jason Ling
2024-03-06 14:34 (ALTech) Sangmin Choi Status new => assigned
2024-03-06 14:34 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Wooshin Kang
2024-03-06 14:34 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Younkwang Jung
2024-03-06 14:34 (ALTech) Sangmin Choi Issue Monitored: (ALTech) JunGyu Kim
2024-03-06 14:34 (ALTech) Sangmin Choi Note Added: 0015214
2024-03-06 15:04 (SW) Jason Ling Issue Monitored: (SW) Jacky Chiang
2024-03-06 15:04 (SW) Jason Ling Issue Monitored: (SW) Jason Ling
2024-03-06 15:04 (SW) Jason Ling Assigned To (SW) Jason Ling => (SW) Jerry Lin
2024-03-12 08:19 (ALTech) Sangmin Choi Note Added: 0015233
2024-03-14 14:21 (ALTech) Sangmin Choi Note Added: 0015240
2024-03-14 15:04 (SW) Jerry Lin Note Added: 0015241
2024-03-14 16:02 (ALTech) Sangmin Choi Note Added: 0015242
2024-03-14 16:02 (ALTech) Sangmin Choi File Added: test_function_DISPLAY_HDR_GetSupportedInfo.patch
2024-03-15 09:05 (SW) Jerry Lin Note Added: 0015244
2024-03-15 09:26 (ALTech) Sangmin Choi Note Added: 0015245
2024-03-15 09:28 (SW) Jerry Lin Note Added: 0015246
2024-03-15 10:41 (SW) Jerry Lin Note Added: 0015247
2024-03-15 13:37 (ALTech) Sangmin Choi Note Added: 0015250
2024-03-15 15:32 (SW) Jerry Lin Note Added: 0015251
2024-03-15 15:42 (ALTech) Sangmin Choi Note Added: 0015252
2024-03-18 08:29 (ALTech) Sangmin Choi Note Added: 0015255
2024-03-18 16:38 (ALTech) Sangmin Choi Note Added: 0015259
2024-03-18 16:38 (ALTech) Sangmin Choi Assigned To (SW) Jerry Lin => (ALTech) Sangmin Choi
2024-03-19 13:17 (ALTech) Sangmin Choi Note Added: 0015261
2024-03-19 13:18 (ALTech) Sangmin Choi Assigned To (ALTech) Sangmin Choi => (SW) Jerry Lin
2024-03-19 13:22 (ALTech) Sangmin Choi Issue Monitored: (SW) Kerwin Chen
2024-03-19 13:23 (ALTech) Sangmin Choi Note Added: 0015262
2024-03-20 09:24 (SW) Jerry Lin Note Added: 0015267
2024-03-20 09:24 (SW) Jerry Lin File Added: HDR.xlsx
2024-03-20 09:49 (ALTech) Sangmin Choi Note Added: 0015268
2024-03-25 16:00 (ALTech) Sangmin Choi Note Added: 0015295
2024-03-25 20:07 (SW) Jerry Lin Note Added: 0015296
2024-03-28 08:31 (ALTech) Sangmin Choi Note Added: 0015321
2024-03-28 15:48 (SW) Jerry Lin Note Added: 0015327
2024-03-29 08:55 (ALTech) Sangmin Choi Note Added: 0015330
2024-03-29 09:46 (ALTech) Sangmin Choi Note Added: 0015332
2024-03-29 10:34 (SW) Jerry Lin Note Added: 0015333
2024-03-29 11:33 (ALTech) Sangmin Choi Assigned To (SW) Jerry Lin => (ALTech) Sangmin Choi
2024-03-29 11:33 (ALTech) Sangmin Choi Status assigned => closed
2024-03-29 11:33 (ALTech) Sangmin Choi Resolution open => fixed
2024-03-29 11:33 (ALTech) Sangmin Choi Note Added: 0015336